gh-111178: fix UBSan failures in Modules/_tkinter.c - #129795
Merged
encukou merged 10 commits intoFeb 26, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
marked this pull request as ready for review
February 8, 2025 09:37
encukou
reviewed
Feb 24, 2025
Comment thread
Modules/_tkinter.c
picnixz
marked this pull request as draft
February 24, 2025 13:14
Copy link
Copy Markdown
Member
Author
|
Independently of this PR, but can't we actually transform static types of tkinter into heap types? |
Sorry, something went wrong.
picnixz
marked this pull request as ready for review
February 25, 2025 11:32
encukou
approved these changes
Feb 25, 2025
encukou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good! One nitpick left:
Sorry, something went wrong.
Comment thread
Modules/_tkinter.c
Outdated
Copy link
Copy Markdown
Member
See #103092 (comment) & #103108 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.