gh-124703: Add documentation and whatsnew entry for pdb exit change - #129818
Merged
gaogaotiantian merged 2 commits intoFeb 8, 2025
Merged
gh-124703: Add documentation and whatsnew entry for pdb exit change#129818gaogaotiantian merged 2 commits into
gaogaotiantian merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There are a couple of warnings. I don't know what they are about. 
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yeah I'm still not super familiar with rst, but obviously I should do an "absolute" ref instead of a "relative" one :) |
Sorry, something went wrong.
iritkatriel
approved these changes
Feb 7, 2025
StanFromIreland
approved these changes
Feb 7, 2025
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like this is something we should mention in whatsnew for 3.14 because it is a behavioral change and we don't want to surprise users (or at least have an explanation after we surprise them). Also the documetation for pdb should be updated. I did not mention EOF and <Enter> in the prompt because it's too cumbersome, but the documentation seems like the place to mention it.
📚 Documentation preview 📚: https://cpython-previews--129818.org.readthedocs.build/