bpo-26978: Implement pathlib.Path.link_to (Using os.link) by nanjekyejoannah · Pull Request #12990 · python/cpython · GitHub

I have implemented pathlib.Path.link_to.

https://bugs.python.org/issue26978

Thanks for submitting this PR. You'll find some comments below.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

… into issue26978

I have made the requested changes; please review again.

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

Thank you @nanjekyejoannah. I will wait for CI to pass and then merge if green.

Suggested change

      
            (Contributed by Joannah Nanjekye in :issue:`26978`)
          
            (Contributed by Joannah Nanjekye in :issue:`26978`.)

It should be pathlib.Path.link_to(), not pathlib.path.link_to().

Also, double backqoutes should be used here instead of single backquotes (as per https://devguide.python.org/documenting/#inline-markup). The following could also be used:

:meth:`pathlib.Path.link_to()`

Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (GH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

…17225) Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> (cherry picked from commit 092435e) Co-authored-by: Toke Høiland-Jørgensen <toke@redhat.com>

Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (GH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> (cherry picked from commit 092435e) Co-authored-by: Toke Høiland-Jørgensen <toke@redhat.com>

…17225) Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

nanjekyejoannah added 2 commits April 27, 2019 21:43

Implement pathlib.Path.link

4335641

Fix documentation

95aadda

the-knights-who-say-ni added the CLA signed label Apr 28, 2019

bedevere-bot added the awaiting review label Apr 28, 2019

📜🤖 Added by blurb_it.

51f9654

auvipy approved these changes Apr 28, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Apr 28, 2019

pitrou requested changes Apr 29, 2019

View reviewed changes

Comment thread Doc/library/pathlib.rst Outdated

Comment thread Doc/library/pathlib.rst

Comment thread Lib/pathlib.py Outdated

Comment thread Lib/test/test_pathlib.py

bedevere-bot removed the awaiting core review label Apr 29, 2019

bedevere-bot added the awaiting changes label Apr 29, 2019

nanjekyejoannah added 2 commits May 4, 2019 08:42

Implement pathlib.Path.link

a418a80

Merge branch 'issue26978' of https://github.com/nanjekyejoannah/cpython …

126c89b

… into issue26978

bedevere-bot removed the awaiting changes label May 4, 2019

bedevere-bot added the awaiting change review label May 4, 2019

tirkarthi reviewed May 4, 2019

View reviewed changes

Comment thread Doc/whatsnew/3.8.rst Outdated

nanjekyejoannah and others added 2 commits May 4, 2019 10:54

fix Doc

0852e47

update news entry

3291e1c

pitrou changed the title bpo-26978: Implement pathlib.Path.link (Using os.link) bpo-26978: Implement pathlib.Path.link_to (Using os.link) May 4, 2019

pitrou approved these changes May 4, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 4, 2019

ZackerySpytz reviewed May 4, 2019

View reviewed changes

pitrou merged commit 6b5b013 into python:master May 4, 2019

bedevere-bot removed the awaiting merge label May 4, 2019

nanjekyejoannah deleted the issue26978 branch May 4, 2019 15:30

ZackerySpytz reviewed May 4, 2019

View reviewed changes

tohojo mentioned this pull request Nov 15, 2019

bpo-38811: Check for presence of os.link method in pathlib #17170

Merged

tohojo mentioned this pull request Nov 18, 2019

bpo-38811: Check for presence of os.link method in pathlib (v2) #17225

Merged

miss-islington mentioned this pull request Dec 16, 2019

[3.8] bpo-38811: Check for presence of os.link method in pathlib (GH-17225) #17626

Merged

chris-eibl mentioned this pull request Feb 13, 2025

Support PGO for clang-cl #130090

Closed

bpo-26978: Implement pathlib.Path.link_to (Using os.link) by nanjekyejoannah · Pull Request #12990 · python/cpython · GitHub

Repository navigation

bpo-26978: Implement pathlib.Path.link_to (Using os.link) - #12990

bpo-26978: Implement pathlib.Path.link_to (Using os.link)#12990
pitrou merged 7 commits into
python:masterfrom
nanjekyejoannah:issue26978

nanjekyejoannah commented Apr 28, 2019 •
edited
Loading

Uh oh!

Uh oh!

nanjekyejoannah commented Apr 28, 2019

Uh oh!

pitrou left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 29, 2019

Uh oh!

nanjekyejoannah commented May 4, 2019

Uh oh!

bedevere-bot commented May 4, 2019

Uh oh!

Uh oh!

pitrou commented May 4, 2019

Uh oh!

ZackerySpytz May 4, 2019

Uh oh!

ZackerySpytz May 4, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

+              Added :meth:`pathlib.Path.link_to()` which creates a hard link pointing
+              to a path.
+              (Contributed by Joannah Nanjekye in :issue:`26978`)

	(Contributed by Joannah Nanjekye in :issue:`26978`)
	(Contributed by Joannah Nanjekye in :issue:`26978`.)

		@@ -0,0 +1,2 @@
		`pathlib.path.link_to()` is now implemented. It creates a hard link pointing

bpo-26978: Implement pathlib.Path.link_to (Using os.link) by nanjekyejoannah · Pull Request #12990 · python/cpython · GitHub

Repository navigation

bpo-26978: Implement pathlib.Path.link_to (Using os.link) - #12990

bpo-26978: Implement pathlib.Path.link_to (Using os.link)#12990pitrou merged 7 commits intopython:masterpython/cpython:masterfrom nanjekyejoannah:issue26978nanjekyejoannah/cpython:issue26978Copy head branch name to clipboard

Conversation

nanjekyejoannah commented Apr 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nanjekyejoannah commented Apr 28, 2019

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 29, 2019

Uh oh!

nanjekyejoannah commented May 4, 2019

Uh oh!

bedevere-bot commented May 4, 2019

Uh oh!

Uh oh!

pitrou commented May 4, 2019

Uh oh!

ZackerySpytz May 4, 2019

Choose a reason for hiding this comment

Uh oh!

ZackerySpytz May 4, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bpo-26978: Implement pathlib.Path.link_to (Using os.link)#12990
pitrou merged 7 commits into
python:masterfrom
nanjekyejoannah:issue26978

nanjekyejoannah commented Apr 28, 2019 •
edited
Loading