gh-130139: always check ast node type in ast.parse() with ast input by iritkatriel · Pull Request #130140 · python/cpython · GitHub

Issue: ast.parse() without optimize=True doesn't error on invalid AST type #130139

📚 Documentation preview 📚: https://cpython-previews--130140.org.readthedocs.build/

…nput

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

pythongh-130139 : always check ast node type in ast.parse() with ast i…

117152f

…nput

iritkatriel requested review from Eclips4, JelleZijlstra, ericsnowcurrently and isidentical as code owners February 15, 2025 01:48

bedevere-app Bot added the awaiting core review label Feb 15, 2025

bedevere-app Bot mentioned this pull request Feb 15, 2025

ast.parse() without optimize=True doesn't error on invalid AST type #130139

Closed

Eclips4 approved these changes Feb 15, 2025

View reviewed changes

Comment thread Doc/whatsnew/3.14.rst Outdated

Comment thread Misc/NEWS.d/next/Library/2025-02-15-01-37-47.gh-issue-130139.gntc7B.rst Outdated

bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 15, 2025

Apply suggestions from code review

75307d5

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

iritkatriel merged commit c9b1bf3 into python:main Feb 16, 2025

bedevere-app Bot removed the awaiting merge label Feb 16, 2025

gh-130139: always check ast node type in ast.parse() with ast input by iritkatriel · Pull Request #130140 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-130139: always check ast node type in ast.parse() with ast input - #130140

gh-130139: always check ast node type in ast.parse() with ast input#130140
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:gh-130139

iritkatriel commented Feb 15, 2025 •
edited by github-actions Bot
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-130139: always check ast node type in ast.parse() with ast input by iritkatriel · Pull Request #130140 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-130139: always check ast node type in ast.parse() with ast input - #130140

gh-130139: always check ast node type in ast.parse() with ast input#130140iritkatriel merged 2 commits intopython:mainpython/cpython:mainfrom iritkatriel:gh-130139iritkatriel/cpython:gh-130139Copy head branch name to clipboard

Conversation

iritkatriel commented Feb 15, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-130139: always check ast node type in ast.parse() with ast input#130140
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:gh-130139

iritkatriel commented Feb 15, 2025 •
edited by github-actions Bot
Loading