Repository navigation
GH-125413: Add private pathlib.Path method to write metadata - #130238
Merged
barneygale merged 4 commits intoFeb 26, 2025
Merged
barneygale merged 4 commits into
barneygale merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Replace `WritablePath._copy_writer` with a new `_write_info()` method. This method allows the target of a `copy()` to preserve metadata. Replace `pathlib._os.CopyWriter` and `LocalCopyWriter` classes with new `copy_file()` and `copy_info()` functions. The `copy_file()` function uses `source_path.info` wherever possible to save on `stat()`s.
15 of 17 tasks
barneygale
marked this pull request as draft
February 17, 2025 20:05
barneygale
commented
Feb 21, 2025
Comment thread
Lib/pathlib/_os.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace WritablePath._copy_writer with a new _write_info() method. This method allows the target of a copy() to preserve metadata.
Replace pathlib._os.CopyWriter and LocalCopyWriter classes with new copy_file() and copy_info() functions. The copy_file() function uses source_path.info wherever possible to save on stat()s.