gh-130132: add an explicit close() call to urlopen examples without with by Mr-Sunglasses · Pull Request #130280 · python/cpython · GitHub

fix: #130132

Issue: docs: add an explicit close() call to urlopen examples without with #130132

📚 Documentation preview 📚: https://cpython-previews--130280.org.readthedocs.build/

…hout with

@sobolevn @picnixz ptal.

Thanks for correcting the missing close() bug in one example, there are 2 remaining.

…ication

Thanks for correcting the missing close() bug in one example, there are 2 remaining.

Thanks @opk12 for suggestions, added it in the remaining examples.

@sobolevn I have made the requested changes; please review again.

Thanks for making the requested changes!

: please review the changes made to this pull request.

@sobolevn I have made the requested changes; please review again.

Thanks for making the requested changes!

: please review the changes made to this pull request.

let's use 4 spaces

Co-authored-by: sobolevn <mail@sobolevn.me>

@sobolevn I have made the requested changes; please review again.

Requesting @sobolevn , @picnixz for review.

There are some usages of opener.open (L1319, L1340) that could be in a "with". Please check the entire file with occurrences of open and urlopen. TiA.

…x/130132

@picnixz I've make the requested changes. please review again 😄 .

TiA. 🙏🏻

Other examples use `f` as the response variable.

Thanks @Mr-Sunglasses for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

…pythonGH-130280) (cherry picked from commit 77d2fd4) Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com> Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

GH-131394 is a backport of this pull request to the 3.13 branch.

…pythonGH-130280) (cherry picked from commit 77d2fd4) Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com> Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

GH-131395 is a backport of this pull request to the 3.12 branch.

GH-130280) (#131394) gh-130132: properly free resources in `urrlib.urlopen` examples (GH-130280) (cherry picked from commit 77d2fd4) Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com> Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

GH-130280) (#131395) gh-130132: properly free resources in `urrlib.urlopen` examples (GH-130280) (cherry picked from commit 77d2fd4) Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com> Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…python#130280) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

pythongh-130132 : add an explicit close() call to urlopen examples wit…

acafffd

…hout with

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 18, 2025

bedevere-app Bot mentioned this pull request Feb 18, 2025

docs: add an explicit close() call to urlopen examples without with #130132

Closed

Mr-Sunglasses added 2 commits February 19, 2025 01:28

pythongh-130132 : add an explicit close() in Use of Basic HTTP Authent…

3c00f5d

…ication

pythongh-130132 : add an explicit close() in Adding HTTP headers

379b075

sobolevn reviewed Feb 18, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst

sobolevn reviewed Feb 19, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst Outdated

fix: use context manager in urllib.request examples

c9fbdb0

bedevere-app Bot added awaiting change review and removed awaiting review labels Feb 20, 2025

Mr-Sunglasses requested a review from sobolevn February 20, 2025 18:40

sobolevn reviewed Feb 25, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst Outdated

Comment thread Doc/library/urllib.request.rst Outdated

Mr-Sunglasses and others added 2 commits February 26, 2025 01:34

fix: spaces in the docs,

05d0a4e

Co-authored-by: sobolevn <mail@sobolevn.me>

fix: spaces in the docs.

9f1344a

Co-authored-by: sobolevn <mail@sobolevn.me>

Mr-Sunglasses commented Feb 25, 2025

View reviewed changes

Mr-Sunglasses requested a review from sobolevn February 25, 2025 20:05

picnixz self-requested a review February 28, 2025 21:27

picnixz reviewed Mar 1, 2025

View reviewed changes

Mr-Sunglasses added 2 commits March 3, 2025 23:40

Merge branch 'main' into fix/130132

90332d1

docs: Add context manager in examples of urllib.request

97e6b18

Mr-Sunglasses added 2 commits March 9, 2025 23:33

Merge branch 'fix/130132' of github.com:Mr-Sunglasses/cpython into fi…

098ba79

…x/130132

Merge branch 'main' into fix/130132

e56cc3e

Mr-Sunglasses commented Mar 9, 2025

View reviewed changes

Mr-Sunglasses requested a review from picnixz March 9, 2025 18:20

picnixz self-assigned this Mar 12, 2025

picnixz reviewed Mar 12, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst Outdated

picnixz reviewed Mar 18, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst Outdated

picnixz reviewed Mar 18, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst Outdated

picnixz reviewed Mar 18, 2025

View reviewed changes

Comment thread Doc/library/urllib.request.rst Outdated

use f as the as variable

3825537

Other examples use `f` as the response variable.

picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Mar 18, 2025

picnixz approved these changes Mar 18, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting change review labels Mar 18, 2025

picnixz enabled auto-merge (squash) March 18, 2025 09:23

picnixz merged commit 77d2fd4 into python:main Mar 18, 2025

github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 18, 2025

bedevere-app Bot removed the awaiting merge label Mar 18, 2025

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 18, 2025

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 18, 2025

gh-130132: add an explicit close() call to urlopen examples without with by Mr-Sunglasses · Pull Request #130280 · python/cpython · GitHub

Repository navigation

gh-130132: add an explicit close() call to urlopen examples without with - #130280

gh-130132: add an explicit close() call to urlopen examples without with#130280picnixz merged 11 commits intopython:mainpython/cpython:mainfrom Mr-Sunglasses:fix/130132Mr-Sunglasses/cpython:fix/130132Copy head branch name to clipboard

Conversation

Mr-Sunglasses commented Feb 18, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mr-Sunglasses commented Feb 18, 2025

Uh oh!

opk12 commented Feb 18, 2025

Uh oh!

Mr-Sunglasses commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

Mr-Sunglasses commented Feb 20, 2025

Uh oh!

bedevere-app Bot commented Feb 20, 2025

Uh oh!

Mr-Sunglasses commented Feb 24, 2025

Uh oh!

bedevere-app Bot commented Feb 24, 2025

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mr-Sunglasses left a comment

Choose a reason for hiding this comment

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Mr-Sunglasses left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 18, 2025

Uh oh!

bedevere-app Bot commented Mar 18, 2025

Uh oh!

bedevere-app Bot commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-130132: add an explicit close() call to urlopen examples without with#130280
picnixz merged 11 commits into
python:mainfrom
Mr-Sunglasses:fix/130132

Mr-Sunglasses commented Feb 18, 2025 •
edited by github-actions Bot
Loading