gh-124703: Change back to raising bdb.BdbQuit when exiting pdb in 'inline' mode in a REPL session - #130395
Merged
gaogaotiantian merged 14 commits intoFeb 25, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
Comment thread
Lib/pdb.py
Outdated
Comment thread
Lib/test/test_pdb.py
Outdated
Comment thread
Lib/test/test_pdb.py
Outdated
Comment thread
Misc/NEWS.d/next/Library/2025-02-21-09-05-44.gh-issue-124703.AMJD4Y.rst
Outdated
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
…MJD4Y.rst Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Comment thread
Lib/test/test_pdb.py
Outdated
Comment thread
Lib/test/test_pdb.py
Outdated
Comment thread
Lib/test/test_pdb.py
Comment thread
Lib/test/test_pdb.py
Outdated
gaogaotiantian
approved these changes
Feb 25, 2025
Copy link
Copy Markdown
Member
|
Thank you for the PR! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the merge! And thanks for being super responsive and all your hard work on pdb! |
Sorry, something went wrong.
This was referenced Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change should mean it's again possible to call breakpoint() in a REPL session and return to the REPL session with q/quit/exit/EOF.
The test has a slight workaround/hack because I couldn't figure out how to call breakpoint() and simulate using pdb interactively within a simulated REPL session in a subprocess. After set_trace() was called, pdb would receive an EOF and exit before it could receive further commands.
If there's interest, I could also add the code from PR129768 to shorten the BdbQuit traceback by one frame.