GH-91079: Revert "GH-91079: Implement C stack limits using addresses, not counters. (GH-130007)" for now - #130413
Merged
encukou merged 1 commit intoFeb 24, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… counters. (pythonGH-130007)" for now Unfortunatlely, the change broke some buildbots. This reverts commit 2498c22.
encukou
requested review from
Eclips4,
JelleZijlstra,
carljm,
ericsnowcurrently,
iritkatriel,
isidentical,
lysnikolaou,
markshannon,
pablogsal and
rhettinger
as code owners
February 21, 2025 16:25
Copy link
Copy Markdown
Member
|
Grrr. I was just about to merge #130398. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Sorry! I hoped 3 days would be enough for comments. Not over the weekend, I guess. PEP-11 calls for applying reverts/fixes immediately, and I'm under some pressure to do that more consistently. I hope dealing with reverts (i.e. cherry-pick the orignal PR in the fix) is not too hard. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunatlely, the change broke some buildbots. To make them usable again, and allow time for proper fixes, it's best to revert for now.
This reverts commit 2498c22.
📚 Documentation preview 📚: https://cpython-previews--130413.org.readthedocs.build/