FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-130160: Convert `webbrowser` docs to use `.. option` directive by sobolevn · Pull Request #130497 · python/cpython · GitHub

/ cpython Public

gh-130160: Convert webbrowser docs to use .. option directive - #130497

Closed
sobolevn wants to merge 1 commit into
python:mainfrom
sobolevn:issue-130160-webbrowser
ConversationCommits (1)ChecksFiles changed
Closed

gh-130160: Convert webbrowser docs to use .. option directive#130497
sobolevn wants to merge 1 commit into
python:mainfrom
sobolevn:issue-130160-webbrowser

Conversation

sobolevn commented Feb 24, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Feb 24, 2025
bedevere-app Bot mentioned this pull request Feb 24, 2025
Closed
6 tasks
sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 24, 2025
hugovk approved these changes Feb 24, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

(Let's leave easy issues for newcomers ;)

Comment thread Doc/library/webbrowser.rst

.. option:: -t, --new-tab

Opens the URL in a new browser page ("tab").

hugovk Feb 24, 2025 •
edited by picnixz
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we can update this too, browser tabs are now well established compared with when this feature was introduced in 2005: e8f244305ef4

(Opera had tabs in 2000, Safari in 2003, IE7 in 2006: https://en.wikipedia.org/wiki/Tab_(interface)#History)

Suggested change
Opens the URL in a new browser page ("tab").
Opens the URL in a new browser tab.

sobolevn Feb 24, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oups, I missed the label :)

picnixz approved these changes Feb 24, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM modulo Hugo's comment.

sobolevn closed this Feb 24, 2025

sobolevn commented Feb 24, 2025

Copy link
Copy Markdown
Member Author

Let's keep it for someone else :)

picnixz commented Feb 24, 2025

Copy link
Copy Markdown
Member

Let's keep it for someone else :)

What altruism :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
picnixz picnixz approved these changes
AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL