Repository navigation
gh-130482: Add ability to specify name for tkinter.OptionMenu and tkinter.ttk.OptionMenu - #130502
Merged
serhiy-storchaka merged 6 commits intoMay 2, 2025
Merged
serhiy-storchaka merged 6 commits into
serhiy-storchaka merged 6 commits into
Conversation
…er.ttk.OptionMenu`
kurawlefaraaz
approved these changes
Feb 24, 2025
Copy link
Copy Markdown
Contributor
Author
|
@serhiy-storchaka Sorry to bother you, can you please help review this PR? Thank you so much! |
Sorry, something went wrong.
serhiy-storchaka
self-requested a review
May 1, 2025 14:24
serhiy-storchaka
approved these changes
May 1, 2025
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 👍
I left few suggestions for tests. You can accept them or reject.
Sorry, something went wrong.
Comment thread
Lib/test/test_tkinter/test_widgets.py
Outdated
Comment thread
Lib/test/test_ttk/test_extensions.py
Outdated
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
Contributor
Author
Thank you for helping to review this PR. I have accepted all of your suggestions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you for your contribution @Xiaokang2022. |
Sorry, something went wrong.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…nd tkinter.ttk.OptionMenu (pythonGH-130502)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.