FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-128231: Use `runcode()` return value for failing early (GH-129488) by miss-islington · Pull Request #130513 · python/cpython · GitHub

/ cpython Public

[3.13] gh-128231: Use runcode() return value for failing early (GH-129488) - #130513

Merged
hugovk merged 1 commit into
python:3.13from
miss-islington:backport-7ed3dc6-3.13
Mar 28, 2025
ConversationCommits (1)ChecksFiles changed
Merged

[3.13] gh-128231: Use runcode() return value for failing early (GH-129488)#130513
hugovk merged 1 commit into
python:3.13from
miss-islington:backport-7ed3dc6-3.13

Conversation

miss-islington commented Feb 24, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 7ed3dc6)

Co-authored-by: Bartosz Sławecki bartoszpiotrslawecki@gmail.com

pythongh-128231: Use runcode() return value for failing early (pyth…
2a59b10 
…onGH-129488)

(cherry picked from commit 7ed3dc6)

Co-authored-by: Bartosz Sławecki <bartoszpiotrslawecki@gmail.com>
bedevere-app Bot added the topic-repl Related to the interactive shell label Feb 24, 2025
bedevere-app Bot mentioned this pull request Feb 24, 2025
Merged
bedevere-app Bot mentioned this pull request Feb 24, 2025
Closed
kumaraditya303 removed their request for review March 25, 2025 09:08
hugovk merged commit 8f6a9aa into python:3.13 Mar 28, 2025

hugovk commented Mar 28, 2025

Copy link
Copy Markdown
Member

This 3.13 backport is failing GHA and buildbots, it must have gotten out of sync between last CI run and merge.

Let's revert this 3.13 backport to get the CI back to green.

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

My intuition is that it can be simply worked-around by not printing a literal value, but e.g. 'after' + 'wards'. I suspect the input got into output, and that causes the failure.

hugovk added a commit to hugovk/cpython that referenced this pull request Mar 28, 2025
Revert "[3.13] pythongh-128231: Use runcode() return value for fail…
f32bd0a 
…ing early (pythonGH-129488) (python#130513)"

This reverts commit 8f6a9aa.
hugovk mentioned this pull request Mar 28, 2025
Closed

hugovk commented Mar 28, 2025

Copy link
Copy Markdown
Member

In the meantime, I've made PR #131834 to revert.

bedevere-app Bot commented Mar 28, 2025

Copy link
Copy Markdown

GH-131834 is a backport of this pull request to the 3.13 branch.

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

Fixing in the original branch (#129488).

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

I guess I'll need to open another PR.

This was referenced Mar 28, 2025
Merged
Merged
miss-islington deleted the backport-7ed3dc6-3.13 branch January 2, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

encukou

Labels

topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL