gh-128002: use efficient linked list impl for eager tasks in asyncio - #130518
Merged
kumaraditya303 merged 5 commits intoMar 3, 2025
Merged
gh-128002: use efficient linked list impl for eager tasks in asyncio#130518kumaraditya303 merged 5 commits into
kumaraditya303 merged 5 commits into
Conversation
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
February 24, 2025 16:10
9 tasks
itamaro
approved these changes
Mar 2, 2025
itamaro
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
left a few comment wording suggestions, otherwise looks great, thanks @kumaraditya303 !
Sorry, something went wrong.
Co-authored-by: Itamar Oren <itamarost@gmail.com>
Co-authored-by: Itamar Oren <itamarost@gmail.com>
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit 7e3b788. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/506/builds/10005 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line 391, in _inner
func(self, **args)
~~~~^^^^^^^^^^^^^^
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line 279, in test_force_shutdown_workers
self.assertEqual(worker_process.exitcode, -signal.SIGTERM)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 255 != -15
Traceback (most recent call last):
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line 391, in _inner
func(self, **args)
~~~~^^^^^^^^^^^^^^
File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line 281, in test_force_shutdown_workers
self.assertEqual(worker_process.exitcode, -signal.SIGKILL)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 255 != -9
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.