FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-85012: Properly reset `msgctxt` when compiling messages with `msgfmt` by tomasr8 · Pull Request #130525 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-85012: Properly reset msgctxt when compiling messages with msgfmt #130525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
Mar 13, 2025
Conversation 12 Commits 8 Checks 0 Files changed
Merged

gh-85012: Properly reset msgctxt when compiling messages with msgfmt #130525

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7e4bbb5
Add human-readable snapshots
tomasr8 Feb 17, 2025
69402a5
Reset context when adding a message
tomasr8 Feb 17, 2025
741c35c
Add news entry
tomasr8 Feb 24, 2025
bcb8533
Use nicer sorting for snapshots
tomasr8 Feb 25, 2025
bb68538
Temporarily revert fix and regenerate snapshots
tomasr8 Feb 25, 2025
8295b2b
Re-apply fix and regenerate snapshots
tomasr8 Feb 25, 2025
97d0a0f
Add regression tests
tomasr8 Feb 25, 2025
d4dcc87
Merge remote-tracking branch 'upstream/main' into msgfmt-ctxt
tomasr8 Feb 25, 2025
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
Add regression tests
  • Loading branch information
tomasr8 committed Feb 25, 2025
commit 97d0a0fe05579fa8a8e8bdd58a5ea8d5772cef1f
22 changes: 22 additions & 0 deletions Lib/test/test_tools/test_msgfmt.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,28 @@ def test_compilation(self):

self.assertDictEqual(actual._catalog, expected._catalog)

def test_translations(self):
with open(data_dir / 'general.mo', 'rb') as f:
t = GNUTranslations(f)

self.assertEqual(t.gettext('foo'), 'foo')
self.assertEqual(t.gettext('bar'), 'baz')
self.assertEqual(t.pgettext('abc', 'foo'), 'bar')
self.assertEqual(t.pgettext('xyz', 'foo'), 'bar')
self.assertEqual(t.gettext('Multilinestring'), 'Multilinetranslation')
self.assertEqual(t.gettext('"escapes"'), '"translated"')
self.assertEqual(t.gettext('\n newlines \n'), '\n translated \n')
self.assertEqual(t.ngettext('One email sent.', '%d emails sent.', 1),
'One email sent.')
self.assertEqual(t.ngettext('One email sent.', '%d emails sent.', 2),
'%d emails sent.')
self.assertEqual(t.npgettext('abc', 'One email sent.',
'%d emails sent.', 1),
'One email sent.')
self.assertEqual(t.npgettext('abc', 'One email sent.',
'%d emails sent.', 2),
'%d emails sent.')

def test_invalid_msgid_plural(self):
with temp_cwd():
Path('invalid.po').write_text('''\
Expand Down
Back | FazBrowse Home | New Git URL