FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127785: Limit check labels github action permission by shenxianpeng · Pull Request #130596 · python/cpython · GitHub

/ cpython Public

gh-127785: Limit check labels github action permission - #130596

Merged
AA-Turner merged 1 commit into
python:mainfrom
shenxianpeng:update-github-action-permission
Feb 26, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-127785: Limit check labels github action permission#130596
AA-Turner merged 1 commit into
python:mainfrom
shenxianpeng:update-github-action-permission

Conversation

shenxianpeng commented Feb 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

The workflow checks for labels on pull requests using the mheap/github-action-required-labels action. Since this action only reads PR labels without modifying them, it does not require write permissions.

I tested it in my test-repo/pull/11, removed issues: write and changed pull-requests: write to pull-requests: read to limit permissions, The workflow functioned as expected.

ghost commented Feb 26, 2025 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Feb 26, 2025
Closed
AA-Turner merged commit 5ba69e7 into python:main Feb 26, 2025
hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 26, 2025

miss-islington-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

Thanks @shenxianpeng for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

Thanks @shenxianpeng for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

Sorry, @shenxianpeng and @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ba69e747fa9da984a307b2cbc9f82bac1e0db04 3.13

miss-islington-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

Sorry, @shenxianpeng and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ba69e747fa9da984a307b2cbc9f82bac1e0db04 3.12

shenxianpeng deleted the update-github-action-permission branch February 27, 2025 01:22

hugovk commented Feb 27, 2025

Copy link
Copy Markdown
Member

@shenxianpeng Please could you take care of the backports? Thanks!

shenxianpeng added a commit to shenxianpeng/cpython that referenced this pull request Feb 27, 2025
pythongh-127785: Reduce permissions in the check labels workflow (p…
3738cdc 
…ython#130596)

(cherry picked from commit 5ba69e7)
shenxianpeng added a commit to shenxianpeng/cpython that referenced this pull request Feb 27, 2025
[3.13] pythongh-127785: Reduce permissions in the check labels work…
768a971 
…flow (pythonGH-130596)

(cherry picked from commit 5ba69e7)

Co-authored-by: shenxianpeng <xianpeng.shen@gmail.com>

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130623 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 27, 2025

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130623 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 27, 2025

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130624 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130625 is a backport of this pull request to the 3.12 branch.

shenxianpeng commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

@shenxianpeng Please could you take care of the backports? Thanks!

Sure, I've already taken care of the backports.

hugovk pushed a commit that referenced this pull request Feb 27, 2025
[3.12] gh-127785: Limit check labels github action permission (GH-130596
e280c49 
) (#130625)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Feb 27, 2025
[3.13] gh-127785: Limit check labels github action permission (GH-130596
676ceca 
) (#130623)

Co-authored-by: shenxianpeng <xianpeng.shen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

AA-Turner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL