FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-121970: Extract ``issue_role`` into a new extension by AA-Turner · Pull Request #130615 · python/cpython · GitHub

/ cpython Public

GH-121970: Extract issue_role into a new extension - #130615

Merged
AA-Turner merged 5 commits into
python:mainfrom
AA-Turner:docs/issue-role
Feb 27, 2025
ConversationCommits (5)ChecksFiles changed
Merged

GH-121970: Extract issue_role into a new extension#130615
AA-Turner merged 5 commits into
python:mainfrom
AA-Turner:docs/issue-role

Conversation

AA-Turner commented Feb 26, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 26, 2025
AA-Turner requested a review from hugovk as a code owner February 26, 2025 22:51
AA-Turner changed the title GH-121970: Extract issue_role into a new extension GH-121970: Extract issue_role into a new extension Feb 26, 2025
bedevere-app Bot mentioned this pull request Feb 26, 2025
Open
hugovk reviewed Feb 27, 2025
View reviewed changes
Comment thread Doc/tools/extensions/issue_role.py
Comment thread Doc/tools/extensions/issue_role.py Outdated
Comment thread Doc/tools/extensions/issue_role.py
return [prb], [msg]

issue_url = self.ISSUE_URI.format(issue)
refnode = nodes.reference(issue, f"bpo-{issue}", refuri=issue_url)

hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Here we're passing something like 12345 and bpo-12345 as the first two arguments.

Before we were passing something like bpo-12345 and bpo-12345 for both.

I see the second one is used in the refnode:

<reference refuri="https://bugs.python.org/issue?@action=redirect&bpo=13936">bpo-13936</reference>

How is the first one used?

AA-Turner Feb 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's the docutils rawsource, it should reflect what was actually written in the document.

Sphinx uses this for translation, I don't think these nodes are translatable but I'll double check.

A

AA-Turner Feb 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See e.g. https://github.com/python/python-docs-fr/blob/3.13/whatsnew/3.13.po#L394-L399, the whole role is included in the translation string.

hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So should it match 12345 or bpo-12345?

hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(Unresolving so the question isn't hidden :)

AA-Turner Feb 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The text of what is actually written in the document, so "14159".

Comment thread Doc/tools/extensions/issue_role.py Outdated
AA-Turner and others added 2 commits February 27, 2025 14:21
Hugo's review
6fa8680 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Revert TC=False
3b46c04
hugovk approved these changes Feb 27, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

AA-Turner merged commit 043ab3a into python:main Feb 27, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Feb 27, 2025

miss-islington-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

AA-Turner deleted the docs/issue-role branch February 27, 2025 19:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2025
pythonGH-121970: Extract issue_role into a new extension (pythonG…
9bc2331 
…H-130615)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130651 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 27, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2025
pythonGH-121970: Extract issue_role into a new extension (pythonG…
de65166 
…H-130615)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130652 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 27, 2025
AA-Turner added a commit that referenced this pull request Feb 27, 2025
[3.13] GH-121970: Extract issue_role into a new extension (GH-130615
b53065a 
) (#130651)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Feb 27, 2025
[3.12] GH-121970: Extract issue_role into a new extension (GH-130615
245ca26 
) (#130652)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL