FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix Sphinx documentation warnings in `collections.rst` by Viicos · Pull Request #130629 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix Sphinx documentation warnings in collections.rst - #130629

Merged
hugovk merged 1 commit into
python:mainfrom
Viicos:collections-docs-warning
Mar 3, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-101100: Fix Sphinx documentation warnings in collections.rst#130629
hugovk merged 1 commit into
python:mainfrom
Viicos:collections-docs-warning

Conversation

Viicos commented Feb 27, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 27, 2025
bedevere-app Bot mentioned this pull request Feb 27, 2025
Closed
Viicos commented Feb 27, 2025
View reviewed changes
Comment thread Doc/library/collections.rst

.. versionchanged:: 3.7
Removed the *verbose* parameter and the :attr:`_source` attribute.
Removed the *verbose* parameter and the :attr:`!_source` attribute.

Viicos Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should _source be documented?

hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need, it's been removed.

rhettinger removed their request for review February 27, 2025 17:12
hugovk approved these changes Feb 28, 2025
View reviewed changes
Comment thread Doc/library/collections.rst

.. versionchanged:: 3.7
Removed the *verbose* parameter and the :attr:`_source` attribute.
Removed the *verbose* parameter and the :attr:`!_source` attribute.

hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need, it's been removed.

hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Mar 3, 2025
hugovk merged commit 373eb1b into python:main Mar 3, 2025

miss-islington-app Bot commented Mar 3, 2025

Copy link
Copy Markdown

Thanks @Viicos for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 3, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2025
pythongh-101100: Fix Sphinx documentation warnings in `collections.rs…
e684390 
…t` (pythonGH-130629)

(cherry picked from commit 373eb1b)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>

bedevere-app Bot commented Mar 3, 2025

Copy link
Copy Markdown

GH-130779 is a backport of this pull request to the 3.13 branch.

miss-islington-app Bot commented Mar 3, 2025

Copy link
Copy Markdown

Sorry, @Viicos and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 373eb1b47af6843678c477b237d787c04dda2818 3.12

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 3, 2025
hugovk pushed a commit that referenced this pull request Mar 3, 2025
[3.13] gh-101100: Fix Sphinx documentation warnings in `collections.r…
f51a748 
…st` (GH-130629) (#130779)

gh-101100: Fix Sphinx documentation warnings in `collections.rst` (GH-130629)
(cherry picked from commit 373eb1b)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull request Mar 3, 2025
[3.12] pythongh-101100: Fix Sphinx documentation warnings in `collect…
8ca209c 
…ions.rst` (pythonGH-130629)

(cherry picked from commit 373eb1b)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>

bedevere-app Bot commented Mar 3, 2025

Copy link
Copy Markdown

GH-130782 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 3, 2025
hugovk added a commit that referenced this pull request Mar 3, 2025
[3.12] gh-101100: Fix Sphinx documentation warnings in `collections.r…
a22cfd4 
…st` (GH-130629) (#130782)

(cherry picked from commit 373eb1b)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Viicos deleted the collections-docs-warning branch April 6, 2025 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

hugovk

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL