Repository navigation
gh-130655: Increase test coverage of gettext._expand_lang - #130656
Merged
serhiy-storchaka merged 1 commit intoFeb 28, 2025
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Feb 28, 2025
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 👍
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 28, 2025
…thonGH-130656) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Copy link
Copy Markdown
|
GH-130671 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 28, 2025
…thonGH-130656) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Copy link
Copy Markdown
|
GH-130672 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 28, 2025
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help with properly testing gettext.find which calls _expand_lang.
With these tests, the function is fully covered: