Adds a Py_STACKREF_CLOSE_DEBUG #definable option to track closed stack refs. This gives us precise locations for the the initial close and subsequent use or close.
For example, there is a use-after-free in BINARY_OP_INPLACE_ADD_UNICODE (which this PR does not fix)
On main the error message is this:
Fatal Python error: _Py_stackref_record_borrow:
Invalid StackRef with ID 15618638
With this PR it looks like this:
Fatal Python error: _Py_stackref_record_borrow:
Borrow of closed ref ID 15609203 at Python/generated_cases.c.h:59.
Referred to instance of str at 0x55a2b6c5ff10.
Closed at Python/generated_cases.c.h:344
(I've reformatted the messages for clarity, but the content is unchanged):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Py_STACKREF_CLOSE_DEBUG #definable option to track closed stack refs. This gives us precise locations for the the initial close and subsequent use or close.
For example, there is a use-after-free in BINARY_OP_INPLACE_ADD_UNICODE (which this PR does not fix)
On main the error message is this:
With this PR it looks like this:
(I've reformatted the messages for clarity, but the content is unchanged):