FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118518: Minor improvements to perf docs by stratakis · Pull Request #130866 · python/cpython · GitHub

/ cpython Public

gh-118518: Minor improvements to perf docs - #130866

Merged
pablogsal merged 1 commit into
python:mainfrom
stratakis:perf_docs
Mar 10, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-118518: Minor improvements to perf docs#130866
pablogsal merged 1 commit into
python:mainfrom
stratakis:perf_docs

Conversation

stratakis commented Mar 5, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 5, 2025
github-project-automation Bot moved this to Todo in Docs PRs Mar 5, 2025
bedevere-app Bot mentioned this pull request Mar 5, 2025
Closed

stratakis commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

cc @pablogsal

jstasiak reviewed Mar 8, 2025
View reviewed changes

jstasiak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are these changes actually related to the linked ticket?

FWIW I'd probably not attach this PR to a ticket that's been closed for that long.

stratakis commented Mar 9, 2025

Copy link
Copy Markdown
Contributor Author

The -k flag for perf is required for jited code so it's related to the linked ticket where the support was initially implemented. The rename of the script harmonizes the commands with the rest of the examples there.

pablogsal approved these changes Mar 10, 2025
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Thanks for the PR @stratakis

pablogsal added the needs backport to 3.13 bugs and security fixes label Mar 10, 2025
pablogsal enabled auto-merge (squash) March 10, 2025 21:51
pablogsal merged commit ecdf6b1 into python:main Mar 10, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 10, 2025

miss-islington-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

Thanks @stratakis for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2025
pythongh-118518: Minor improvements to perf docs (pythonGH-130866)
c7a085c 
Minor improvements to perf docs
(cherry picked from commit ecdf6b1)

Co-authored-by: stratakis <cstratak@redhat.com>

bedevere-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

GH-131059 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 10, 2025
pablogsal pushed a commit that referenced this pull request Mar 28, 2025
[3.13] gh-118518: Minor improvements to perf docs (GH-130866) (#131059)
7f7fc54 
gh-118518: Minor improvements to perf docs (GH-130866)

Minor improvements to perf docs
(cherry picked from commit ecdf6b1)

Co-authored-by: stratakis <cstratak@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
+1 more reviewer
jstasiak jstasiak left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL