FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-129573: Fix possible abort from non-string suggestions in `calculate_suggestions`/`_Py_CalculateSuggestions` by devdanzin · Pull Request #130997 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-129573: Fix possible abort from non-string suggestions in calculate_suggestions/_Py_CalculateSuggestions - #130997

Open
devdanzin wants to merge 9 commits into
python:mainfrom
devdanzin:fix_nonstring_suggestions2
ConversationCommits (9)ChecksFiles changed
Open

gh-129573: Fix possible abort from non-string suggestions in calculate_suggestions/_Py_CalculateSuggestions#130997
devdanzin wants to merge 9 commits into
python:mainfrom
devdanzin:fix_nonstring_suggestions2

Conversation

devdanzin commented Mar 9, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR adds a simple check that suggestion candidates are strings in calculate_suggestions(3.12)/_Py_CalculateSuggestions(main), avoiding an abort in debug builds from code like below:

import runpy
runpy._run_module_code("blech", {0: "", "bluch": ""}, "")

The abort only happens in 3.12, because the code in main checks for non-string candidates in _suggestions__generate_suggestions_impl. However, since the affected code is still present in main, this PR is against that branch.

In main, the code above exits the new REPL, which will be reported as a new issue with associated PR.

Found using fusil by @vstinner.

bedevere-app Bot mentioned this pull request Mar 9, 2025
Closed
picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Mar 9, 2025

vstinner commented Mar 10, 2025

Copy link
Copy Markdown
Member

test_traceback is failing on the CI.

tomasr8 removed the needs backport to 3.12 only security fixes label Apr 10, 2025

python-cla-bot Bot commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

vstinner reviewed Apr 18, 2025
View reviewed changes
Comment thread Python/suggestions.c

vstinner commented Apr 18, 2025

Copy link
Copy Markdown
Member

@devdanzin: Tests are failing on your PR, and you didn't sign the CLA. What's the status of this PR?

devdanzin commented Apr 18, 2025

Copy link
Copy Markdown
Member Author

I'm sorry, I've left this one fall behind. Would you like to take it over?

I have signed the CLA and even contributed some trivial code, I'll wait to see if it's a CLA bot issue or my CLA status changed to unverified somehow.

vstinner reviewed May 3, 2025
View reviewed changes
Comment thread Lib/test/test_traceback.py Outdated
def test_suggestions_do_not_trigger_with_non_string_candidates(self):
def run_module_code():
import runpy
runpy._run_module_code("blech", {0: "", "bluch": ""}, "")

vstinner May 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
runpy._run_module_code("blech", {0: "", "bluch": ""}, "")
# non-string global variable
runpy._run_module_code("blech", {0: "", "bluch": ""}, "")

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
devdanzin mentioned this pull request May 29, 2025
Merged
vstinner reviewed Jun 4, 2025
View reviewed changes
Comment thread Lib/test/test_traceback.py

self.assertRaises(
TypeError,
_suggestions._generate_suggestions,

vstinner Jun 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

_suggestions._generate_suggestions() checks if all elements are strings before calling _Py_CalculateSuggestions(). So this test doesn't check changed code.

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 22, 2026
serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label May 30, 2026
github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 31, 2026

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

awaiting review needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL