FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93096: Remove `-t` and `-v` flags from `pickletools` cli by donbarbos · Pull Request #131039 · python/cpython · GitHub

/ cpython Public

gh-93096: Remove -t and -v flags from pickletools cli - #131039

Merged
vstinner merged 1 commit into
python:mainfrom
donbarbos:issue-93096-pickletools
Mar 11, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-93096: Remove -t and -v flags from pickletools cli#131039
vstinner merged 1 commit into
python:mainfrom
donbarbos:issue-93096-pickletools

Conversation

donbarbos commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm also going to send a similar PR for the pickle module (for same flags)

And I'm not sure if I should send a separate PR or I can add it here

donbarbos changed the title Remove -t and -v flags from pickletools cli gh-93096: Remove -t and -v flags from pickletools cli Mar 10, 2025
bedevere-app Bot mentioned this pull request Mar 10, 2025
Open
27 tasks

donbarbos commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

I also made sure that unit tests call doctests, we add them here:

cpython/Lib/test/test_pickletools.py

Lines 517 to 519 in 98fa4a4

def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite(pickletools))
return tests

cc @serhiy-storchaka

vstinner approved these changes Mar 11, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I confirm that these options are not documented at: https://docs.python.org/dev/library/pickletools.html#command-line-usage

@serhiy-storchaka: Are you ok with removing these undocumented pickletools CLI options?

donbarbos commented Mar 11, 2025

Copy link
Copy Markdown
Contributor Author

He commented this changes here: #130973 (comment)

serhiy-storchaka approved these changes Mar 11, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

vstinner merged commit 3ddf983 into python:main Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL