FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93096: Update and document `pickle` CLI by donbarbos · Pull Request #131097 · python/cpython · GitHub

/ cpython Public

gh-93096: Update and document pickle CLI - #131097

Merged
vstinner merged 17 commits into
python:mainfrom
donbarbos:issue-93096-pickle-cli-docs
Mar 14, 2025
ConversationCommits (17)ChecksFiles changed
Merged

gh-93096: Update and document pickle CLI#131097
vstinner merged 17 commits into
python:mainfrom
donbarbos:issue-93096-pickle-cli-docs

Conversation

donbarbos commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 11, 2025
github-project-automation Bot moved this to Todo in Docs PRs Mar 11, 2025
bedevere-app Bot mentioned this pull request Mar 11, 2025
Open
27 tasks

donbarbos commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

cc @vstinner as author of idea

in issue #130160 we're making backports for 3.12 and 3.13 versions. since this is a similar PR I suggest to stick to the same strategy

vstinner approved these changes Mar 11, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

cc @picnixz

picnixz reviewed Mar 12, 2025
View reviewed changes
Comment thread Doc/library/pickle.rst Outdated
Comment thread Doc/library/pickle.rst Outdated
Update Doc/library/pickle.rst
5909db4 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
hugovk reviewed Mar 13, 2025
View reviewed changes
Comment thread Doc/library/pickle.rst Outdated
Comment thread Doc/library/pickle.rst Outdated
Comment thread Doc/library/pickle.rst Outdated
donbarbos requested review from hugovk and picnixz March 13, 2025 15:16
picnixz reviewed Mar 13, 2025
View reviewed changes
Comment thread Lib/pickle.py Outdated
picnixz approved these changes Mar 13, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Last nit and LGTM.

Comment thread Doc/library/pickle.rst Outdated
picnixz changed the title gh-93096: Add CLI docs for pickle gh-93096: Update and document CLI pickle Mar 13, 2025
picnixz changed the title gh-93096: Update and document CLI pickle gh-93096: Update and document pickle CLI Mar 13, 2025
Update Doc/library/pickle.rst
cefd8a4 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz commented Mar 13, 2025

Copy link
Copy Markdown
Member

I'll wait for Hugo's review and then we can probably merge it (just for a last checkup)

vstinner approved these changes Mar 14, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Doc/library/pickle.rst Outdated
Update Doc/library/pickle.rst
29d1360 
Co-authored-by: Victor Stinner <vstinner@python.org>
hugovk approved these changes Mar 14, 2025
View reviewed changes
Comment thread Lib/pickle.py
donbarbos and others added 2 commits March 14, 2025 10:15
Update Lib/pickle.py
3dd66f2 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
back sort_dicts=True
ff22e97
hugovk reviewed Mar 14, 2025
View reviewed changes
Comment thread Lib/pickle.py Outdated

hugovk commented Mar 14, 2025

Copy link
Copy Markdown
Member

Do we need a NEWS file? This started out as docs only, but we're changing the code in pickle.py here. Although it's in code that was not documented before now, so maybe not needed?

picnixz commented Mar 14, 2025

Copy link
Copy Markdown
Member

We changed the code but it was already not documented. I don't think it's worth a What's New entry, but a small NEWS entry may be nice. We could make it under Library to mention that we now use pprint.pp instead of pprint.pprint to render pickle files.

vstinner commented Mar 14, 2025

Copy link
Copy Markdown
Member

Please don't replace pprint.pprint() with pprint.pp() in this PR but write a separated change for that.

donbarbos commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ok, I reverted using pprint instead of pp

hugovk commented Mar 14, 2025

Copy link
Copy Markdown
Member

Thanks, remember to push :)

hugovk reviewed Mar 14, 2025
View reviewed changes
Comment thread Lib/pickle.py Outdated
Update Lib/pickle.py
8f1af6e 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
vstinner merged commit f9d0531 into python:main Mar 14, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 14, 2025

vstinner commented Mar 14, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
pythongh-93096: Update and document pickle CLI (python#131097)
f430877 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
vstinner vstinner approved these changes
hugovk hugovk approved these changes
JacobCoffee JacobCoffee approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL