FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-128002: add test_asyncio.test_free_threading to tsan tests by kumaraditya303 · Pull Request #131106 · python/cpython · GitHub

/ cpython Public

gh-128002: add test_asyncio.test_free_threading to tsan tests - #131106

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:asyncio
Mar 11, 2025
Merged

gh-128002: add test_asyncio.test_free_threading to tsan tests#131106
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:asyncio

Conversation

kumaraditya303 commented Mar 11, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Mar 11, 2025
9 tasks
kumaraditya303 changed the title gh-128002: add test_asyncio.test_free_threading to tsan CI gh-128002: add test_asyncio.test_free_threading to tsan tests Mar 11, 2025

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do you have time to look at the other TSAN reported races in test_asyncio?

Copy link
Copy Markdown
Contributor Author

Do you have time to look at the other TSAN reported races in test_asyncio?

What are the other TSAN races?

Copy link
Copy Markdown
Contributor

If you run the test_asyncio tests under TSAN you'll see a bunch of races. Here are the ones I've seen when running it:

https://gist.github.com/colesbury/210e1e1c60d38dbfd92e5226d7848b38

There are also a few additional ones when run with the GIL enabled, because it doesn't use some of the atomic operations that we use in the free threading build.

I wouldn't worry about the frame_clear race for now, but I think the other ones, including the file descriptor races can be fixed.

Copy link
Copy Markdown
Contributor Author

If you run the test_asyncio tests under TSAN you'll see a bunch of races. Here are the ones I've seen when running it:

https://gist.github.com/colesbury/210e1e1c60d38dbfd92e5226d7848b38

There are also a few additional ones when run with the GIL enabled, because it doesn't use some of the atomic operations that we use in the free threading build.

Thanks! I will look into it.

kumaraditya303 merged commit 2407049 into python:main Mar 11, 2025
kumaraditya303 deleted the asyncio branch March 11, 2025 20:03

Copy link
Copy Markdown
Contributor

To follow up on my previous comment: I think that fixing the file descriptor races might involve changing the test code to avoid concurrent close() operations with operations that use the sockets, but I'm not entirely sure.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL