Repository navigation
gh-127667: refactor and improve _hashopenssl.c error branches - #131145
picnixz merged 7 commits into
Conversation
Sorry, something went wrong.
|
I'm backporting this because future changes will likely have conflicts since error branches would be handled differently. |
Sorry, something went wrong.
gpshead
left a comment
There was a problem hiding this comment.
thanks, nice refactoring for better maintainability.
Sorry, something went wrong.
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
|
Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker ac50ece6cea8745834e4ec0a9617809a51245bfc 3.13 |
Sorry, something went wrong.
|
Sorry, @picnixz, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker ac50ece6cea8745834e4ec0a9617809a51245bfc 3.12 |
Sorry, something went wrong.
…python#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
|
GH-131347 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…python#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message. # Conflicts: # Modules/_hashopenssl.c
|
GH-131348 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
…python#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
#131145) (#131348) gh-127667: refactor and improve `_hashopenssl.c` error branches (#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message. (cherry-picked from commit ac50ece).
#131145) (#131347) gh-127667: refactor and improve `_hashopenssl.c` error branches (#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message. (cherry-picked from commit ac50ece).
Previously, we had a single _setException() helper and most of the time, we always did the same thing. Sometimes it's also not necessary to actually create a va_list.