gh-130940: Modify default behavior of PyConfig.use_system_logger to enable on iOS - #131172
Merged
freakboy3742 merged 1 commit intoMar 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
!buildbot iOS |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 0f9661c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131172%2Fmerge The command will test the builders whose names match following regular expression: iOS The builders matched are:
|
Sorry, something went wrong.
ned-deily
approved these changes
Mar 13, 2025
ned-deily
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
4 tasks
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…er` to enable on iOS (python#131172) Modify default behavior of use_system_log to enable on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#127592 added the PyConfig.use_system_logger configuration flag; this was backported to 3.13 in #127754.
This introduced an ABI breakage in 3.13.2; the flag will be removed from 3.13 by #131129.
However, the functional effect of the flag is required on iOS so that the logs generated by the simulator can be observed at all. As a general rule, there's very little reason you'd not want stdout and stderr routed to the system log on iOS - every BeeWare app, for example, includes std-nslog, which implements effectively the same behavior.
To allow for this, #131129 modifies the behavior on iOS to always use the system logger for stdout/stderr. This PR ensures that behaviour will be consistent by default between 3.13 and 3.14 - use of the system log is enabled by default on iOS, and disabled by default on macOS.
📚 Documentation preview 📚: https://cpython-previews--131172.org.readthedocs.build/