FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131204: Fix `difflib.HtmlDiff` may not use monospaced font by Wulian233 · Pull Request #131221 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131204: Fix difflib.HtmlDiff may not use monospaced font - #131221

Merged
hugovk merged 4 commits into
python:mainfrom
Wulian233:difflib-font
Mar 14, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-131204: Fix difflib.HtmlDiff may not use monospaced font#131221
hugovk merged 4 commits into
python:mainfrom
Wulian233:difflib-font

Conversation

Wulian233 commented Mar 14, 2025 •
edited by hugovk
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Mar 14, 2025
Closed

Wulian233 commented Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

CC @hugovk request review :)

picnixz requested a review from hugovk March 14, 2025 09:45
hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Mar 14, 2025

hugovk commented Mar 14, 2025

Copy link
Copy Markdown
Member

Thank you!

hugovk enabled auto-merge (squash) March 14, 2025 10:22
hugovk merged commit 7fd6160 into python:main Mar 14, 2025

miss-islington-app Bot commented Mar 14, 2025

Copy link
Copy Markdown

Thanks @Wulian233 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 14, 2025

Copy link
Copy Markdown

Sorry, @Wulian233 and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7fd61607cd28ec466717c78adfb1eb5b63add1f0 3.13

miss-islington-app Bot commented Mar 14, 2025

Copy link
Copy Markdown

Sorry, @Wulian233 and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7fd61607cd28ec466717c78adfb1eb5b63add1f0 3.12

Wulian233 deleted the difflib-font branch March 14, 2025 10:48

hugovk commented Mar 14, 2025

Copy link
Copy Markdown
Member

@Wulian233 Please could you take care of backports? Thank you!

This was referenced Mar 14, 2025
Merged
Merged

Wulian233 commented Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

@Wulian233 Please could you take care of backports? Thank you!

Sure!

#131242
#131243

bedevere-app Bot commented Mar 14, 2025

Copy link
Copy Markdown

GH-131242 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 14, 2025

bedevere-app Bot commented Mar 14, 2025

Copy link
Copy Markdown

GH-131243 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 14, 2025
hugovk pushed a commit that referenced this pull request Mar 14, 2025
[3.12] gh-131204: Fix difflib.HtmlDiff may not use monospaced font (G…
e364a42 
…H-131221) (#131243)

(cherry picked from commit 7fd6160)
hugovk pushed a commit that referenced this pull request Mar 14, 2025
[3.13] gh-131204: Fix difflib.HtmlDiff may not use monospaced font (G…
130fa4c 
…H-131221) (#131242)

(cherry picked from commit 7fd6160)
mikec9 pushed a commit to mikec9/cpython that referenced this pull request Mar 14, 2025
[3.12] pythongh-131204: Fix difflib.HtmlDiff may not use monospaced…
5463012 
… font (pythonGH-131221) (python#131243)

(cherry picked from commit 7fd6160)
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
pythongh-131204: Fix difflib.HtmlDiff may not use monospaced font (p…
14d55c1 
…ython#131221)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

difflib-generated HTML file does not use monospaced font

2 participants

Back | FazBrowse Home | New Git URL