FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-36818: Add PyInterpreterState.runtime field. by ericsnowcurrently · Pull Request #13129 · python/cpython · GitHub

/ cpython Public

bpo-36818: Add PyInterpreterState.runtime field. - #13129

Merged
ericsnowcurrently merged 4 commits into
python:masterfrom
ericsnowcurrently:interp-runtime-field
Jun 1, 2019
ConversationCommits (4)ChecksFiles changed
Merged

bpo-36818: Add PyInterpreterState.runtime field.#13129
ericsnowcurrently merged 4 commits into
python:masterfrom
ericsnowcurrently:interp-runtime-field

Conversation

ericsnowcurrently commented May 6, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

ericsnowcurrently force-pushed the interp-runtime-field branch 2 times, most recently from 33fc33e to 7a22095 Compare May 7, 2019 13:30
vstinner requested changes May 10, 2019
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I disagree with the overall approach. Maybe I misunderstood you.
https://bugs.python.org/issue36818#msg342043

Comment thread Include/internal/pycore_object.h Outdated
Comment thread Include/internal/pycore_pystate.h Outdated

bedevere-bot commented May 10, 2019

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

vstinner closed this May 10, 2019

vstinner commented May 10, 2019

Copy link
Copy Markdown
Member

Eric is working on a different approach: https://bugs.python.org/issue36854

ericsnowcurrently commented May 31, 2019

Copy link
Copy Markdown
Member Author

The GC stuff is orthogonal to adding PyInterpreterState.runtime. I still plan on merging this after resolving merge conflicts and any feedback.

ericsnowcurrently commented Jun 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

FYI, I've trimmed the PR down. The changes I've removed can wait until later.

ericsnowcurrently merged commit 396e0a8 into python:master Jun 1, 2019
ericsnowcurrently deleted the interp-runtime-field branch June 1, 2019 03:16
vstinner added a commit that referenced this pull request Jun 4, 2019
Revert "bpo-36818: Add PyInterpreterState.runtime field. (gh-13129)" (G…
0fd2c30 
…H-13795)

This reverts commit 396e0a8.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-36818: Add PyInterpreterState.runtime field. (pythongh-13129)
f79dabd 
https://bugs.python.org/issue36818
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Revert "bpo-36818: Add PyInterpreterState.runtime field. (pythongh-13129
72ba7cf 
)" (pythonGH-13795)

This reverts commit 396e0a8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner requested changes
brettcannon Awaiting requested review from brettcannon
encukou Awaiting requested review from encukou
ncoghlan Awaiting requested review from ncoghlan
warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL