FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-131296: fix clang-cl warnings on Windows in blake2module.c by chris-eibl · Pull Request #131299 · python/cpython · GitHub

/ cpython Public

GH-131296: fix clang-cl warnings on Windows in blake2module.c - #131299

Merged
gpshead merged 1 commit into
python:mainfrom
chris-eibl:fix_clangcl_blake2module
Mar 15, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-131296: fix clang-cl warnings on Windows in blake2module.c#131299
gpshead merged 1 commit into
python:mainfrom
chris-eibl:fix_clangcl_blake2module

Conversation

chris-eibl commented Mar 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fix

1>..\Modules\blake2module.c(77,9): warning : variable 'eax1' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(77,19): warning : variable 'ebx1' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,9): warning : variable 'eax7' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,29): warning : variable 'ecx7' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,39): warning : variable 'edx7' set but not used [-Wunused-but-set-variable]

we see them two (non-PGO) or three times, because the _freeze_module compiles blake2module.c, too.

I think this is a skip news.

bedevere-app Bot mentioned this pull request Mar 15, 2025
Closed
gpshead approved these changes Mar 15, 2025
View reviewed changes
Comment thread Modules/blake2module.c
edx7 = info7[3];
#else
#endif
(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;

gpshead Mar 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LOL... definitely fighting against the compiler's idea of best practices here using useless no-op statements as a way to work around it. i wish we could disable a specific warning for a whole block of code. i feel like a future compiler will notice that these are useless and stop considering them a "use".

chris-eibl Mar 15, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was just the least minimal change to silence the warning :)

Luckily, I think we'll never have to fear that this will ever need a change: that (void) pattern is adapted by all known compilers for ages - and I think this will stay.

gpshead merged commit faa80fc into python:main Mar 15, 2025
picnixz approved these changes Mar 15, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ideally, we would have used (void) ... in the elif branch but it would be an overkill for foolish consistency.

Comment thread Modules/blake2module.c
(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;
(void) eax7; (void) ebx7; (void) ecx7; (void) edx7;
#endif

picnixz Mar 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you remove the double blank lines L98/L99 please? TiA

picnixz commented Mar 15, 2025

Copy link
Copy Markdown
Member

Oh it was merged :')

chris-eibl deleted the fix_clangcl_blake2module branch March 15, 2025 19:18
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
pythonGH-131296: fix clang-cl warnings on Windows in blake2module.c (p…
1b7fc96 
…ython#131299)

work around unimportant clang-cl warnings in blake2module.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
picnixz picnixz approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL