FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131238: Remove pycore_runtime.h from pycore_pystate.h by vstinner · Pull Request #131356 · python/cpython · GitHub

/ cpython Public

gh-131238: Remove pycore_runtime.h from pycore_pystate.h - #131356

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_deps6
Mar 19, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-131238: Remove pycore_runtime.h from pycore_pystate.h#131356
vstinner merged 1 commit into
python:mainfrom
vstinner:pycore_deps6

Conversation

vstinner commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

  • Remove includes from pycore_pystate.h:

    • pycore_runtime_structs.h
    • pycore_runtime.h
    • pycore_tstate.h
    • pycore_interp.h

  • Reorganize internal headers. Move _gc_thread_state from pycore_interp_structs.h to pycore_tstate.h.

  • Add 3 new header files to PCbuild/pythoncore.vcxproj

bedevere-app Bot mentioned this pull request Mar 17, 2025
Closed
vstinner mentioned this pull request Mar 17, 2025
Merged

vstinner commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

I wrote two PRs to prepare this one:

markshannon commented Mar 17, 2025

Copy link
Copy Markdown
Member

@vstinner why are you doing this right now? If it is so urgent, why did you not do it earlier?

This is creating a lot of churn and merge conflicts for my efforts to sort out the header files ##131351
which I need to fix actual issues around immortality #125174

vstinner commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

@vstinner why are you doing this right now? If it is so urgent, why did you not do it earlier?

Hi, I always wanted to reorganize pycore headers mess, and your issue was a good motivation to work on it. I waited until you merged your PR before pushing my changes. I didn't know that you have further changes in the queue. I will stop for now until you're done to avoid further conflicts.

vstinner marked this pull request as draft March 17, 2025 11:57

markshannon commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Hi, I always wanted to reorganize pycore headers mess, and your issue was a good motivation to work on it.

Glad to be a motivation 🙂

I waited until you merged your PR before pushing my changes. I didn't know that you have further changes in the queue. I will stop for now until you're done to avoid further conflicts.

Thanks. I'll let you know I'm done.

pythongh-131238: Remove pycore_runtime.h from pycore_pystate.h
aedc7f0 
* Remove includes from pycore_pystate.h:

  * pycore_runtime_structs.h
  * pycore_runtime.h
  * pycore_tstate.h
  * pycore_interp.h

* Reorganize internal headers. Move _gc_thread_state from
  pycore_interp_structs.h to pycore_tstate.h.
* Add 3 new header files to PCbuild/pythoncore.vcxproj
vstinner marked this pull request as ready for review March 19, 2025 16:32
vstinner merged commit 4b54031 into python:main Mar 19, 2025
vstinner deleted the pycore_deps6 branch March 19, 2025 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL