GH-127705: Adds the missing bits from #131198 - #131365
Merged
markshannon merged 1 commit intoMar 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
approved these changes
Mar 17, 2025
encukou
reviewed
Mar 19, 2025
Comment thread
Include/internal/pycore_object.h
Comment on lines
+447
to
+449
| #ifdef Py_TRACE_REFS | ||
| _Py_ForgetReference(op); | ||
| #endif |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This addition breaks builds with Py_TRACE_REFS defined.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #131238 is mostly done, we can move this code to where it belongs and add the missing calls to _PyReftracerTrack