Repository navigation
gh-131325: fix sendfile fallback implementation to drain data after writing to transport - #131376
Merged
kumaraditya303 merged 3 commits intoMar 17, 2025
Merged
kumaraditya303 merged 3 commits into
kumaraditya303 merged 3 commits into
Conversation
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
March 17, 2025 18:48
colesbury
approved these changes
Mar 17, 2025
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2025
…fter writing to transport (pythonGH-131376) (cherry picked from commit 94f4d87) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Copy link
Copy Markdown
|
GH-131377 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2025
…fter writing to transport (pythonGH-131376) (cherry picked from commit 94f4d87) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Copy link
Copy Markdown
|
GH-131378 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
colesbury
pushed a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2025
…fter writing to transport (python#131376)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.