Repository navigation
[3.13] gh-131277: allow EnvironmentVarGuard to unset more than one environment variable at once (GH-131280) - #131409
Merged
picnixz merged 3 commits intoMar 18, 2025
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…nvironment variable at once (python#131280) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
3 tasks done
picnixz
marked this pull request as draft
March 18, 2025 12:23
picnixz
marked this pull request as ready for review
March 18, 2025 12:29
Copy link
Copy Markdown
Member
Author
|
Note: some usages were removed from the original commit because the existing code did not use EnvironmentVarGuard at all. Since I didn't want to refactor all the tests, I kept the original code. |
Sorry, something went wrong.
picnixz
deleted the
bp-313/3185e3115c918ec189e16cf9f5b51a13a0146556/unset-env-var-131280
branch
March 18, 2025 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 3185e31)
Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com