FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124666: Improve thread cleanup in test_android by mhsmith · Pull Request #131427 · python/cpython · GitHub

/ cpython Public

gh-124666: Improve thread cleanup in test_android - #131427

Merged
freakboy3742 merged 1 commit into
python:mainfrom
mhsmith:test-android-threading
Mar 18, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-124666: Improve thread cleanup in test_android#131427
freakboy3742 merged 1 commit into
python:mainfrom
mhsmith:test-android-threading

Conversation

mhsmith commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The hanging buildbot in #124666 was caused by a leftover thread created in the test's setUp method. It was supposed to be cleaned up by tearDown, but that isn't called automatically when setUp fails.

I still don't know why the underlying test failure was happening, but I've increased all the timeouts to LOOPBACK_TIMEOUT (10 seconds) in case that makes a difference.

Also cleaned up a couple of other test failure logging issues.

mhsmith added skip news needs backport to 3.13 bugs and security fixes labels Mar 18, 2025
mhsmith requested a review from freakboy3742 as a code owner March 18, 2025 19:45
bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Mar 18, 2025
bedevere-app Bot mentioned this pull request Mar 18, 2025
Closed

mhsmith commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

!buildbot android

bedevere-bot commented Mar 18, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4997d1b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131427%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

freakboy3742 approved these changes Mar 18, 2025
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems like a reasonable set of fixes to me. If nothing else, I guess this means the failure case will actually fail, rather than timing out, which is a definite improvement; maybe the new failure will reveal more detail about why it's failing? (We can but hope :-) )

freakboy3742 merged commit 01b5abb into python:main Mar 18, 2025

miss-islington-app Bot commented Mar 18, 2025

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2025
pythongh-124666: Improve thread cleanup in test_android (pythonGH-131427
7f13df4 
)

Ensures that failures in test setup don't result in dangling threads.
(cherry picked from commit 01b5abb)

Co-authored-by: Malcolm Smith <smith@chaquo.com>

bedevere-app Bot commented Mar 18, 2025

Copy link
Copy Markdown

GH-131433 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2025
freakboy3742 pushed a commit that referenced this pull request Mar 19, 2025
[3.13] gh-124666: Improve thread cleanup in test_android (GH-131427) (#…
ff286a3 
…131433)

Ensures that failures in test setup don't result in dangling threads.
(cherry picked from commit 01b5abb)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
pythongh-124666: Improve thread cleanup in test_android (python#131427)
1a2d35e 
Ensures that failures in test setup don't result in dangling threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intermittent buildbot failure and timeout on Android aarch64

3 participants

Back | FazBrowse Home | New Git URL