FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127833: lexical analysis: Improve section on Names by encukou · Pull Request #131474 · python/cpython · GitHub

/ cpython Public

gh-127833: lexical analysis: Improve section on Names - #131474

Merged
encukou merged 5 commits into
python:mainfrom
encukou:lex-analysis-names
May 21, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-127833: lexical analysis: Improve section on Names#131474
encukou merged 5 commits into
python:mainfrom
encukou:lex-analysis-names

Conversation

encukou commented Mar 19, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Use consistent terminology: "names" are "identifiers", "keywords", and "soft keywords".
Start with the simple case (ASCII), then get more and more technical.
Define NAME in the formal lexical grammar.
Exclude keywords in the identifier definition.

📚 Documentation preview 📚: https://cpython-previews--131474.org.readthedocs.build/

encukou added docs Documentation in the Doc dir skip news labels Mar 19, 2025
github-project-automation Bot moved this to Todo in Docs PRs Mar 19, 2025
StanFromIreland reviewed Mar 19, 2025
View reviewed changes
Comment thread Doc/reference/lexical_analysis.rst Outdated
Comment thread Doc/reference/lexical_analysis.rst Outdated
Comment thread Doc/reference/lexical_analysis.rst Outdated
Comment thread Doc/reference/lexical_analysis.rst Outdated
Update Doc/reference/lexical_analysis.rst
4f33459 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
bedevere-app Bot mentioned this pull request Mar 20, 2025
Open
encukou added the needs backport to 3.14 bugs and security fixes label May 7, 2025

terryjreedy commented May 11, 2025

Copy link
Copy Markdown
Member

I like the re-arrangement and separation of identifier and keyword.

encukou commented May 16, 2025

Copy link
Copy Markdown
Member Author

Thanks for the reviews!
I plan to merge on Wednesday if there are no objections.

encukou merged commit c7364f7 into python:main May 21, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs May 21, 2025

miss-islington-app Bot commented May 21, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

encukou deleted the lex-analysis-names branch May 21, 2025 14:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
e87ea00 
…-131474)

(cherry picked from commit c7364f7)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>

bedevere-app Bot commented May 21, 2025

Copy link
Copy Markdown

GH-134423 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025

miss-islington-app Bot commented May 21, 2025

Copy link
Copy Markdown

Sorry @encukou, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport using cherry_picker on the command line.

cherry_picker c7364f79b2fb01c251e22115875a46a2ec134dcd 3.14

hugovk pushed a commit that referenced this pull request May 26, 2025
[3.14] gh-127833: lexical analysis: Improve section on Names (GH-131474…
ebfd18b 
…) (#134423)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
5b0571c 
…-131474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
encukou mentioned this pull request Jun 18, 2025
Open
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
4abf176 
…-131474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
9c75a60 
…-131474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
7f35068 
…-131474)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes
willingc Awaiting requested review from willingc willingc is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

encukou

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL