FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-131296: fix clang-cl warning on Windows in overlapped.c by chris-eibl · Pull Request #131590 · python/cpython · GitHub

/ cpython Public

GH-131296: fix clang-cl warning on Windows in overlapped.c - #131590

Merged
zooba merged 1 commit into
python:mainfrom
chris-eibl:fix_clangcl_overlapped
Apr 16, 2025
ConversationCommits (1)ChecksFiles changed
Merged

GH-131296: fix clang-cl warning on Windows in overlapped.c#131590
zooba merged 1 commit into
python:mainfrom
chris-eibl:fix_clangcl_overlapped

Conversation

chris-eibl commented Mar 22, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Mar 22, 2025
Closed
chris-eibl commented Mar 22, 2025
View reviewed changes
Comment thread Modules/overlapped.c
@@ -1811,13 +1811,6 @@ _overlapped_Overlapped_WSASendTo_impl(OverlappedObject *self, HANDLE handle,
}
}

chris-eibl Mar 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix warning : unused variable 'Overlapped_WSARecvFrom_doc' [-Wunused-const-variable].

Must be a left-over (and the only PyDoc_STRVAR in overlapped.c).

The currently used PyDoc_STRVAR is here:

cpython/Modules/clinic/overlapped.c.h

Lines 1145 to 1149 in 18249d9

PyDoc_STRVAR(_overlapped_Overlapped_WSARecvFrom__doc__,
"WSARecvFrom($self, handle, size, flags=0, /)\n"
"--\n"
"\n"
"Start overlapped receive.");

chris-eibl commented Apr 15, 2025

Copy link
Copy Markdown
Member Author

@zooba I think this is a simple (and only Windows related) one?

chris-eibl requested a review from zooba April 15, 2025 14:53
zooba merged commit b530e17 into python:main Apr 16, 2025

bedevere-bot commented Apr 16, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x (tier-3) has failed when building commit b530e17.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/3267) and take a look at the build logs.
  4. Check if the failure is related to this commit (b530e17) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/3267

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/73DE2445-3046-432B-A9B5-7C53DF4980AA/data/Containers/Bundle/Application/CA8D8364-E457-49D1-AEAB-EEE00518153C/iOSTestbed.app/python/lib/python3.14/threading.py", line 1079, in _bootstrap_inner
    self._context.run(self.run)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/73DE2445-3046-432B-A9B5-7C53DF4980AA/data/Containers/Bundle/Application/CA8D8364-E457-49D1-AEAB-EEE00518153C/iOSTestbed.app/python/lib/python3.14/threading.py", line 1021, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/73DE2445-3046-432B-A9B5-7C53DF4980AA/data/Containers/Bundle/Application/CA8D8364-E457-49D1-AEAB-EEE00518153C/iOSTestbed.app/python/lib/python3.14/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/Users/buildbot/Library/Developer/XCTestDevices/73DE2445-3046-432B-A9B5-7C53DF4980AA/data/Containers/Bundle/Application/CA8D8364-E457-49D1-AEAB-EEE00518153C/iOSTestbed.app/python/lib/python3.14/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

chris-eibl deleted the fix_clangcl_overlapped branch April 17, 2025 05:10

freakboy3742 commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

The iOS failure is caused by #127108.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL