FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-131296: fix clang-cl warning on Windows in sre.c by chris-eibl · Pull Request #131593 · python/cpython · GitHub

/ cpython Public

GH-131296: fix clang-cl warning on Windows in sre.c #131593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 2 commits into from
Apr 1, 2025
Conversation 9 Commits 2 Checks 0 Files changed
Merged

GH-131296: fix clang-cl warning on Windows in sre.c #131593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547b5c4
fix clangcl warning in sre.c
chris-eibl Mar 22, 2025
853c1ff
just use "#if defined(_MSC_VER) && !defined(__clang__)"
chris-eibl Apr 1, 2025
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion Modules/_sre/sre.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ static unsigned int sre_toupper(unsigned int ch) {

/* -------------------------------------------------------------------- */

#if defined(_MSC_VER)
#if defined(_MSC_VER) && !defined(__clang__)

chris-eibl Apr 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Much simpler - just ignore __clang__ and keep agtw for MSVC.
#pragma optimize("agtw", on) /* doesn't seem to make much difference... */
#pragma warning(disable: 4710) /* who cares if functions are not inlined ;-) */
/* fastest possible local call under MSVC */
Expand Down
Back | FazBrowse Home | New Git URL