FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131725: Generate GNU hash table in `msgfmt.py` by StanFromIreland · Pull Request #131727 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131725: Generate GNU hash table in msgfmt.py - #131727

Open
StanFromIreland wants to merge 13 commits into
python:mainfrom
StanFromIreland:msgfmt-hash
ConversationCommits (13)ChecksFiles changed
Open

gh-131725: Generate GNU hash table in msgfmt.py#131727
StanFromIreland wants to merge 13 commits into
python:mainfrom
StanFromIreland:msgfmt-hash

Conversation

StanFromIreland commented Mar 25, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Mar 25, 2025
Open

StanFromIreland commented Mar 27, 2025

Copy link
Copy Markdown
Member Author

@serhiy-storchaka any thoughts? Anything else you would like to see?

Merge branch 'main' into msgfmt-hash
c123d29 
# Conflicts:
#	Lib/test/test_tools/msgfmt_data/general.mo
#	Lib/test/test_tools/test_msgfmt.py
Regenerate files after merge
4d4e32f
serhiy-storchaka reviewed Mar 29, 2025
View reviewed changes
Comment thread Tools/i18n/msgfmt.py Outdated
Comment thread Tools/i18n/msgfmt.py Outdated
StanFromIreland commented Mar 30, 2025
View reviewed changes
Comment thread Tools/i18n/msgfmt.py

StanFromIreland commented Mar 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

cc @terryjreedy unrelated odd test_idle fails

tomasr8 reviewed Mar 30, 2025
View reviewed changes
Comment thread Tools/i18n/msgfmt.py Outdated
Comment thread Tools/i18n/msgfmt.py Outdated
StanFromIreland commented Mar 30, 2025
View reviewed changes
Comment thread Lib/test/test_tools/test_msgfmt.py Outdated
StanFromIreland marked this pull request as ready for review March 30, 2025 12:43

StanFromIreland commented Mar 30, 2025

Copy link
Copy Markdown
Member Author

!buildbot s390x

bedevere-bot commented Mar 30, 2025

Copy link
Copy Markdown

You don't have write permissions to trigger a build

StanFromIreland commented Mar 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Can a core dev please call them, we should test the tests on a big endian system.

StanFromIreland commented Mar 30, 2025
View reviewed changes
Comment thread Lib/test/test_tools/test_msgfmt.py
Comment on lines +59 to +63
header = struct.unpack("=7I", mo_data[:28])
hash_table_size, hash_table_offset = header[5:7]

hash_tab = struct.unpack(f"={hash_table_size}I",
mo_data[hash_table_offset : hash_table_offset + (hash_table_size * 4)])

StanFromIreland Mar 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I could just hardcode these sizes since we test them below. Is that preferred?

terryjreedy commented Mar 31, 2025

Copy link
Copy Markdown
Member

Test_idle failure did not repeat. Next time, copy specific OS and specific failure if you can find it, into your message.

Merge branch 'main' into msgfmt-hash
bfa32a9 
# Conflicts:
#	Lib/test/test_tools/msgfmt_data/general.mo

StanFromIreland commented May 24, 2025

Copy link
Copy Markdown
Member Author

@serhiy-storchaka friendly ping:-)

StanFromIreland commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

Little ping @tomasr8 / @serhiy-storchaka

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

m-aciek m-aciek left review comments
serhiy-storchaka Awaiting requested review from serhiy-storchaka
tomasr8 Awaiting requested review from tomasr8

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL