Repository navigation
GH-131798: Allow the JIT to remove more int/float/str guards - #131800
Merged
brandtbucher merged 7 commits intoApr 1, 2025
Merged
brandtbucher merged 7 commits into
brandtbucher merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
brandtbucher
requested review from
Fidget-Spinner and
markshannon
as code owners
March 27, 2025 19:38
Copy link
Copy Markdown
Member
Author
One nice unintended effect of this: x + x has only guards the type of x once now, rather than twice. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Looks about 0.5% faster. According to the stats, this avoids:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the definitions of BINARY_OP_SUBSCR_LIST_INT, BINARY_OP_SUBSCR_STR_INT, BINARY_OP_SUBSCR_TUPLE_INT, and STORE_SUBSCR_LIST_INT to use our existing int/str guards for their operands (I'll add new guards for the containers themselves in a follow-up PR). This way, they can be removed when possible.
As part of this change, get rid of the _GUARD_BOTH_FLOAT, _GUARD_BOTH_INT, and _GUARD_BOTH_UNICODE micro-ops, since they just make the abstract interpreter more complicated for not much benefit.