[3.12] gh-128770: raise warnings as errors in test suite - except for test_s… - #131824
Closed
graingert wants to merge 6 commits into
Closed
[3.12] gh-128770: raise warnings as errors in test suite - except for test_s…#131824graingert wants to merge 6 commits into
graingert wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…test_socket which still logs warnings, and internal test warnings that are now logged (python#128973) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> (cherry picked from commit 8a00c9a)
graingert
commented
Mar 28, 2025
Comment thread
Lib/test/support/__init__.py
Outdated
graingert
marked this pull request as ready for review
March 28, 2025 08:57
rhettinger
removed their request for review
March 28, 2025 21:24
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Let's not do this in 3.12 at this point. The next release is the last bugfix release, the value of surfacing warnings is mostly in the long term (making sure future changes don't introduce new warnings), and this has the potential of creating unexpected and possibly irrelevant failures in the test suite, in particular in corner cases not covered by our buildbots. We won't see many new changes in 3.12 after this, and we won't have a lot of opportunities to fix the test failures this might uncover. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocket which still logs warnings, and internal test warnings that are now logged (#128973)
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com
(cherry picked from commit 8a00c9a)