FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131853: Fix test_msgfmt on big-endian platforms by serhiy-storchaka · Pull Request #131879 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131853: Fix test_msgfmt on big-endian platforms - #131879

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test_msgfmt-test_binary_header
Mar 29, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-131853: Fix test_msgfmt on big-endian platforms#131879
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test_msgfmt-test_binary_header

Conversation

serhiy-storchaka commented Mar 29, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Use a generated .mo file instead of a checked in one.

pythongh-131853: Fix test_msgfmt on big-endian platforms
1bd13c8 
Use a generated .mo file instead of a checked in one.
serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Mar 29, 2025
bedevere-app Bot mentioned this pull request Mar 29, 2025
Closed

serhiy-storchaka commented Mar 29, 2025

Copy link
Copy Markdown
Member Author

!buildbot s390x RHEL9 3.x

bedevere-bot commented Mar 29, 2025

Copy link
Copy Markdown

The regex 's390x RHEL9 3.x' did not match any buildbot builder. Is the requested builder in the list of stable builders?

serhiy-storchaka commented Mar 29, 2025

Copy link
Copy Markdown
Member Author

!buildbot s390x

bedevere-bot commented Mar 29, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1bd13c8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131879%2Fmerge

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x RHEL8 Refleaks PR
  • s390x Fedora Rawhide Clang PR
  • s390x Fedora Stable Clang PR
  • s390x Fedora Rawhide LTO PR
  • s390x Fedora Stable Refleaks PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x Fedora Stable Clang Installed PR
  • s390x RHEL9 PR
  • s390x RHEL9 LTO PR
  • s390x Fedora Stable LTO + PGO PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Stable PR
  • s390x RHEL9 Refleaks PR
  • s390x Fedora Rawhide PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x Fedora Rawhide NoGIL PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x RHEL9 LTO + PGO PR
  • s390x Fedora Stable LTO PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL8 PR

StanFromIreland mentioned this pull request Mar 29, 2025
Merged
StanFromIreland approved these changes Mar 29, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, many thanks for fixing my error! Sadly there is no big-endian CI :-(

serhiy-storchaka commented Mar 29, 2025

Copy link
Copy Markdown
Member Author

A simpler fix would be changing the "=" prefix to "<", but we don't test struct.unpack here. We test that msgfmt.py generates expected platform-depending binary header on all platforms.

StanFromIreland commented Mar 29, 2025

Copy link
Copy Markdown
Member

Buildbots passing :-)

picnixz mentioned this pull request Mar 29, 2025
Merged
serhiy-storchaka merged commit c6b1a07 into python:main Mar 29, 2025
serhiy-storchaka deleted the test_msgfmt-test_binary_header branch March 29, 2025 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL