GH-131296: fix clang-cl parentheses warnings on Windows - #131905
Conversation
Sorry, something went wrong.
| } | ||
|
|
||
| while (pCertCtx = CertEnumCertificatesInStore(hCollectionStore, pCertCtx)) { | ||
| while ((pCertCtx = CertEnumCertificatesInStore(hCollectionStore, pCertCtx))) { |
There was a problem hiding this comment.
Fix warning : using the result of an assignment as a condition without parentheses [-Wparentheses].
Sorry, something went wrong.
| } | ||
|
|
||
| while (pCrlCtx = CertEnumCRLsInStore(hCollectionStore, pCrlCtx)) { | ||
| while ((pCrlCtx = CertEnumCRLsInStore(hCollectionStore, pCrlCtx))) { |
There was a problem hiding this comment.
Fix warning : using the result of an assignment as a condition without parentheses [-Wparentheses].
Sorry, something went wrong.
| { | ||
| if (!(info.FileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) || | ||
| !followLinks && IsReparseTagNameSurrogate(info.ReparseTag)) | ||
| (!followLinks && IsReparseTagNameSurrogate(info.ReparseTag))) |
There was a problem hiding this comment.
Fix warning : '&&' within '||' [-Wlogical-op-parentheses].
Sorry, something went wrong.
| exitCode = searchExitCode; | ||
| // If none found, and if permitted, install it | ||
| if (exitCode == RC_NO_PYTHON && isEnvVarSet(L"PYLAUNCHER_ALLOW_INSTALL") || | ||
| if (((exitCode == RC_NO_PYTHON) && isEnvVarSet(L"PYLAUNCHER_ALLOW_INSTALL")) || |
There was a problem hiding this comment.
Fix warning : '&&' within '||' [-Wlogical-op-parentheses].
Sorry, something went wrong.
|
Eh, personally I think these make the code uglier, but there are so few changes that we may as well. Consistency between platforms is worth it. |
Sorry, something went wrong.
I think this is a skip news?
This might seem unneeded, but in the Linux code base, the same warning levels are active, but do not fire.
IMHO, it is better to have these warnings active in the Windows code base, too, and fix them.
Every mainstream compiler warns on this suspicious-looking code.