FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-130655: Add a test for bad magic numbers when parsing gettext MO files by tomasr8 · Pull Request #131909 · python/cpython · GitHub

Repository navigation

gh-130655: Add a test for bad magic numbers when parsing gettext MO files - #131909

Merged
picnixz merged 4 commits into
python:mainfrom
tomasr8:gettext-magic
Apr 4, 2025
Merged

picnixz merged 4 commits into
python:mainfrom
tomasr8:gettext-magic

Conversation

tomasr8 commented Mar 30, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

We're currently not testing that MO files with invalid magic numbers are properly rejected. This PR adds a test for it.

tomasr8 added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Mar 30, 2025
Comment thread Lib/test/test_gettext.py Outdated
tomasr8 requested a review from picnixz April 2, 2025 12:09
picnixz enabled auto-merge (squash) April 4, 2025 13:03
picnixz merged commit 16a6270 into python:main Apr 4, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2025
…ed by `gettext` (pythonGH-131909)

(cherry picked from commit 16a6270)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2025
…ed by `gettext` (pythonGH-131909)

(cherry picked from commit 16a6270)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>

bedevere-app Bot commented Apr 4, 2025

Copy link
Copy Markdown

GH-132077 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 4, 2025

bedevere-app Bot commented Apr 4, 2025

Copy link
Copy Markdown

GH-132078 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 4, 2025
tomasr8 deleted the gettext-magic branch April 4, 2025 13:52
picnixz pushed a commit that referenced this pull request Apr 4, 2025
…sed by `gettext` (GH-131909) (#132077)

gh-130655: Add a test for bad magic numbers in `.mo` files parsed by `gettext` (GH-131909)
(cherry picked from commit 16a6270)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
picnixz pushed a commit that referenced this pull request Apr 4, 2025
…sed by `gettext` (GH-131909) (#132078)

gh-130655: Add a test for bad magic numbers in `.mo` files parsed by `gettext` (GH-131909)
(cherry picked from commit 16a6270)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL