Repository navigation
gh-130655: Add a test for corrupt MO files in gettext - #131911
Merged
picnixz merged 2 commits intoApr 4, 2025
Merged
picnixz merged 2 commits into
picnixz merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
reviewed
Mar 30, 2025
Comment thread
Lib/test/test_gettext.py
picnixz
approved these changes
Mar 30, 2025
picnixz
previously requested changes
Mar 30, 2025
Comment thread
Lib/test/test_gettext.py
This comment was marked as resolved.
Copy link
Copy Markdown
Member
|
sry misclick, I wanted to abandon a pending review :') |
Sorry, something went wrong.
picnixz
self-requested a review
March 30, 2025 19:30
picnixz
approved these changes
Mar 30, 2025
picnixz
enabled auto-merge (squash)
April 4, 2025 13:01
picnixz
disabled auto-merge
April 4, 2025 13:01
picnixz
enabled auto-merge (squash)
April 4, 2025 13:02
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 4, 2025
…honGH-131911) (cherry picked from commit a126cef) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 4, 2025
…honGH-131911) (cherry picked from commit a126cef) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Copy link
Copy Markdown
|
GH-132079 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-132080 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
picnixz
pushed a commit
that referenced
this pull request
Apr 4, 2025
picnixz
pushed a commit
that referenced
this pull request
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to have a corrupt MO file where the message offsets and lengths are larger than the size of the file being parsed. gettext detects this and raises an error, however this is currently not tested. This PR adds a test for it.