gh-107369: Optimise textwrap.indent() - #131923
Merged
AA-Turner merged 1 commit intoMar 31, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
picnixz
approved these changes
Mar 31, 2025
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is funny because this was my very first attempt at CPython: https://github.com/python/cpython/pull/107426/files :') It was rejected at that time (#107426 (comment)) though
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Oh, I didn't see that PR! I think the optimisation is worth it, it's a small change and a reasonable speed-up for the default case (predicate=None). I'll give you co-authored-by credit! A |
Sorry, something went wrong.
methane
reviewed
Apr 15, 2025
| @@ -0,0 +1,2 @@ | |||
| Improved performance of :func:`textwrap.dedent` by an average of ~1.3x. | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
s/dedent/indent/
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #131919, I noticed there was opportunity for improvement here too, a ~30% speed-up.
Benchmarked by indenting the contents of Objects/unicodeobject.c.
A