gh-105499: typing: Remove an unused function - #131946
Merged
JelleZijlstra merged 3 commits intoMar 31, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Leftover from python#105511 I believe. GitHub code search found no usages other than copies of typing.py and lists of stdlib functions.
Copy link
Copy Markdown
Member
|
there's now only one usage of _deduplicate_unhashable with this change; could consider inlining it at the callsite? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Good point, done |
Sorry, something went wrong.
AlexWaygood
approved these changes
Mar 31, 2025
Copy link
Copy Markdown
Member
Author
|
Also noticed some unused imports, so removed those too |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Maybe you should update the title, e.g., gh-105499: remove unused bits post gh-105511 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #105511 I believe. GitHub code search found no usages other
than copies of typing.py and lists of stdlib functions.