FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131938: Update error message for `Element.remove()` when an element is not found by picnixz · Pull Request #131972 · python/cpython · GitHub

/ cpython Public

gh-131938: Update error message for Element.remove() when an element is not found - #131972

Merged
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/xml/remove-error-message-131938
Apr 4, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-131938: Update error message for Element.remove() when an element is not found#131972
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/xml/remove-error-message-131938

Conversation

picnixz commented Apr 1, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 1, 2025
Closed

picnixz commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

@vstinner You suggested this in the other PR, but I don't know if you want me to align the Python implementation as well. More generally, what's the policy when we have a C and a Python implementation: should the exception messages match as much as possible or is it fine to have discrepencies?

vstinner reviewed Apr 1, 2025
View reviewed changes
Comment thread Lib/test/test_xml_etree.py Outdated
Comment thread Misc/NEWS.d/next/Library/2025-04-01-13-44-26.gh-issue-131938.dm4Suq.rst
picnixz commented Apr 1, 2025
View reviewed changes
Comment thread Lib/test/test_xml_etree.py Outdated
vstinner approved these changes Apr 1, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner reviewed Apr 1, 2025
View reviewed changes
Comment thread Lib/test/test_xml_etree.py Outdated
Update Lib/test/test_xml_etree.py
b449607 
Co-authored-by: Victor Stinner <vstinner@python.org>

picnixz commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

I'm actually leaving now so won't have time to push this, I'll do it on Friday though!

picnixz self-assigned this Apr 1, 2025
picnixz enabled auto-merge (squash) April 4, 2025 13:14

vstinner commented Apr 4, 2025

Copy link
Copy Markdown
Member

The Windows x64 job failed with a network issue (urllib.error.HTTPError: HTTP Error 504: Gateway Timeout). I restarted the job.

picnixz merged commit 04bc681 into python:main Apr 4, 2025
picnixz deleted the feat/xml/remove-error-message-131938 branch April 8, 2025 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

picnixz

Labels

topic-XML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL