FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-85302: Add support for BTPROTO_SCO on FreeBSD by serhiy-storchaka · Pull Request #131981 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-85302: Add support for BTPROTO_SCO on FreeBSD - #131981

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:BTPROTO_SCO-FreeBSD
Apr 11, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-85302: Add support for BTPROTO_SCO on FreeBSD#131981
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:BTPROTO_SCO-FreeBSD

Conversation

serhiy-storchaka commented Apr 1, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

BTPROTO_SCO has been supported on FreeBSD since 2008.

📚 Documentation preview 📚: https://cpython-previews--131981.org.readthedocs.build/

pythongh-85302: Add support for BTPROTO_SCO on FreeBSD
2debf1e 
BTPROTO_SCO has been supported on FreeBSD since 2008.
bedevere-app Bot mentioned this pull request Apr 1, 2025
Closed

serhiy-storchaka commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD

bedevere-bot commented Apr 1, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2debf1e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR

vstinner reviewed Apr 2, 2025
View reviewed changes

vstinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

With this change, socket.BTPROTO_SCO constant does not exist on FreeBSD which makes the whole change useless.

The problem is that on my FreeBSD 14.1 VM, the constant is not defined anywhere.grep finds nothing:

$ grep BTPROTO_SCO /usr/include/ -R

Are you sure that FreeBSD supports BTPROTO_SCO?

serhiy-storchaka commented Apr 2, 2025

Copy link
Copy Markdown
Member Author

Indeed, it is defined as BLUETOOTH_PROTO_SCO. I'll fix this, but first we need to add tests. See #132023.

serhiy-storchaka commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD

bedevere-bot commented Apr 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2debf1e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR

vstinner commented Apr 4, 2025

Copy link
Copy Markdown
Member

You need to update your PR to use BLUETOOTH_PROTO_SCO constant, no?

serhiy-storchaka commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

Did I forget to push my changes? Thanks for noticing.

serhiy-storchaka commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD

bedevere-bot commented Apr 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit a62570a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

serhiy-storchaka merged commit e5f8b2c into python:main Apr 11, 2025
serhiy-storchaka deleted the BTPROTO_SCO-FreeBSD branch July 1, 2026 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

OS-freebsd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL