gh-118761: Fix star-import of ast (alternative) - #132025
Merged
AA-Turner merged 2 commits intoApr 2, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
commented
Apr 2, 2025
Comment thread
Lib/_ast_unparse.py
AA-Turner
approved these changes
Apr 2, 2025
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good idea, this also incorporates Victor's suggestion. I've left a suggestion, and I also think we could add the deferred sys import from my PR.
A
Sorry, something went wrong.
AA-Turner
enabled auto-merge (squash)
April 2, 2025 17:56
danielhollas
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AA-Turner this is an alternative to #132024 that feels simpler to me, let me know what you think!