FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: JIT: Narrow the return type of `_CONTAINS_OP_SET` to bool by tomasr8 · Pull Request #132057 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: JIT: Narrow the return type of _CONTAINS_OP_SET to bool #132057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 3 commits into from
Apr 5, 2025
Conversation 2 Commits 3 Checks 0 Files changed
Merged

gh-131798: JIT: Narrow the return type of _CONTAINS_OP_SET to bool #132057

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82f940
Allow the JIT to remove an extra _TO_BOOL_BOOL
tomasr8 Apr 3, 2025
6928552
Add news entry
tomasr8 Apr 3, 2025
52c1a54
Fix linter
tomasr8 Apr 3, 2025
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Fix linter
  • Loading branch information
tomasr8 committed Apr 3, 2025
commit 52c1a54bc77e7d74b0176935f32d9098c0ef4c50
2 changes: 1 addition & 1 deletion Lib/test/test_capi/test_opt.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1621,7 +1621,7 @@ def testfunc(n):
if in_set:
x += 1
Comment on lines +1616 to +1622

tomasr8 Apr 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We might be able to simplify this further, I wasn't sure how much the peepholer would optimize out if I used e.g. 2 in s directly.

brandtbucher Apr 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2 in s would have been fine, but this works well too!
return x

res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
Expand Down
Back | FazBrowse Home | New Git URL