FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-131498: manage stacks automatically by markshannon · Pull Request #132074 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-131498: manage stacks automatically - #132074

Merged
markshannon merged 10 commits into
python:mainfrom
faster-cpython:code-gen-handle-stacks
Apr 4, 2025
ConversationCommits (10)ChecksFiles changed
Merged

GH-131498: manage stacks automatically#132074
markshannon merged 10 commits into
python:mainfrom
faster-cpython:code-gen-handle-stacks

Conversation

markshannon commented Apr 4, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This is the final preparatory PR for top-of-stack caching

This PR:

  • Removes the stack manipulation macros. Instructions must declare values as dead, and let the code generator pop them from the stack
  • Updates the instrumented instructions to be explicit about their stack effect
  • Supports mixing of scalars and arrays on the stack. The code generator pushes scalars to memory if needed for an array.

bedevere-app Bot mentioned this pull request Apr 4, 2025
Closed
StanFromIreland reviewed Apr 4, 2025
View reviewed changes
Comment thread Python/bytecodes.c Outdated
StanFromIreland reviewed Apr 4, 2025
View reviewed changes
Comment thread Python/stackrefs.c Outdated
Apply suggestions from code review
4f8fa37 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

markshannon commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

The MSVC tail calling interpreter failure seems unrelated to this PR.

markshannon merged commit 7099c75 into python:main Apr 4, 2025
markshannon deleted the code-gen-handle-stacks branch April 4, 2025 17:09
picnixz pushed a commit to picnixz/cpython that referenced this pull request Apr 5, 2025
pythonGH-131498: Cases generator: manage stacks automatically (python…
0b437c4 
…GH-132074)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
iritkatriel iritkatriel approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
+1 more reviewer
hpagvn87 hpagvn87 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL